diff --git a/app/BulkActions/Settings/Categories.php b/app/BulkActions/Settings/Categories.php index 39e6d5090..df34e14a2 100644 --- a/app/BulkActions/Settings/Categories.php +++ b/app/BulkActions/Settings/Categories.php @@ -53,6 +53,7 @@ class Categories extends BulkAction public function edit($request) { $selected = $this->getSelectedInput($request); + $types = $this->getCategoryTypes(); return $this->response('bulk-actions.settings.categories.edit', compact('selected', 'types')); diff --git a/app/Http/Controllers/Modals/Categories.php b/app/Http/Controllers/Modals/Categories.php index b2ec178aa..2eaff0d7a 100644 --- a/app/Http/Controllers/Modals/Categories.php +++ b/app/Http/Controllers/Modals/Categories.php @@ -35,36 +35,12 @@ class Categories extends Controller { $type = $request->get('type', Category::ITEM_TYPE); - $type_codes = []; - - switch ($type) { - case Category::INCOME_TYPE: - $types = $this->getIncomeCategoryTypes(); - break; - case Category::EXPENSE_TYPE: - $types = $this->getExpenseCategoryTypes(); - break; - case Category::ITEM_TYPE: - $types = $this->getItemCategoryTypes(); - break; - case Category::OTHER_TYPE: - $types = $this->getOtherCategoryTypes(); - break; - default: - $types = [$type]; - } - - foreach ($types as $type) { - $config_type = config('type.category.' . $type, []); - $type_codes[$type] = empty($config_type['hide']) || ! in_array('code', $config_type['hide']); - } - - $config_type = config('type.category.' . $type, []); - $show_code_field = ! empty($config_type['hide']) && in_array('code', $config_type['hide']) ? false : true; + $category_types = $this->getTypeCategoryTypes($type); + $hide_code_types = $this->hideCodeCategoryTypes($category_types); $categories = collect(); - Category::type($types) + Category::type($category_types) ->enabled() ->orderBy('name') ->get() @@ -76,7 +52,10 @@ class Categories extends Controller ]); }); - $html = view('modals.categories.create', compact('type', 'types', 'categories', 'show_code_field', 'type_codes'))->render(); + $type_group = count($category_types) > 1 ? true : false; + $types = $this->getCategoryTypes(group: true, types: $category_types); + + $html = view('modals.categories.create', compact('type', 'types', 'categories', 'type_group', 'hide_code_types'))->render(); return response()->json([ 'success' => true, diff --git a/app/Http/Controllers/Settings/Categories.php b/app/Http/Controllers/Settings/Categories.php index e3e74dbb0..919c840e2 100644 --- a/app/Http/Controllers/Settings/Categories.php +++ b/app/Http/Controllers/Settings/Categories.php @@ -81,16 +81,17 @@ class Categories extends Controller */ public function create() { - $types = $this->getCategoryTypes(true, true); - $categories = []; - $type_codes = []; foreach (config('type.category') as $type => $config) { - $type_codes[$type] = empty($config['hide']) || ! in_array('code', $config['hide']); $categories[$type] = []; } + $type_group = $this->isGroupCategoryType(); + $hide_code_types = $this->hideCodeCategoryTypes(array_keys($categories)); + + $types = $this->getCategoryTypes(group: $type_group); + Category::enabled()->orderBy('name')->get()->each(function ($category) use (&$categories) { $categories[$category->type][] = [ 'id' => $category->id, @@ -99,7 +100,7 @@ class Categories extends Controller ]; }); - return view('settings.categories.create', compact('types', 'categories', 'type_codes')); + return view('settings.categories.create', compact('types', 'categories', 'type_group', 'hide_code_types')); } /** @@ -163,20 +164,21 @@ class Categories extends Controller */ public function edit(Category $category) { - $types = $this->getCategoryTypes(true, true); - $type_disabled = (Category::where('type', $category->type)->count() == 1) ?: false; $edited_category_id = $category->id; $categories = []; - $type_codes = []; foreach (config('type.category') as $type => $config) { - $type_codes[$type] = empty($config['hide']) || ! in_array('code', $config['hide']); $categories[$type] = []; } + $type_group = $this->isGroupCategoryType(); + $hide_code_types = $this->hideCodeCategoryTypes(array_keys($categories)); + + $types = $this->getCategoryTypes(group: $type_group); + $skip_categories = []; $skip_categories[] = $edited_category_id; @@ -206,7 +208,7 @@ class Categories extends Controller $parent_categories = $categories[$category->type] ?? []; - return view('settings.categories.edit', compact('category', 'types', 'type_disabled', 'categories', 'parent_categories', 'type_codes')); + return view('settings.categories.edit', compact('category', 'types', 'type_disabled', 'categories', 'parent_categories', 'type_group', 'hide_code_types')); } /** diff --git a/app/Listeners/Report/AddExpenseCategories.php b/app/Listeners/Report/AddExpenseCategories.php index 9685b3465..3fb732bf7 100644 --- a/app/Listeners/Report/AddExpenseCategories.php +++ b/app/Listeners/Report/AddExpenseCategories.php @@ -26,7 +26,7 @@ class AddExpenseCategories extends Listener } // send true for add limit on search and filter.. - $event->class->filters['categories'] = $this->getExpenseCategories(true); + $event->class->filters['categories'] = $this->getExpenseCategories(); $event->class->filters['routes']['categories'] = ['categories.index', 'search=type:' . $this->getExpenseCategoryTypes('string') . ' enabled:1']; $event->class->filters['multiple']['categories'] = true; } diff --git a/app/Listeners/Report/AddIncomeCategories.php b/app/Listeners/Report/AddIncomeCategories.php index d492a955d..eed9d1cbe 100644 --- a/app/Listeners/Report/AddIncomeCategories.php +++ b/app/Listeners/Report/AddIncomeCategories.php @@ -26,7 +26,7 @@ class AddIncomeCategories extends Listener } // send true for add limit on search and filter.. - $event->class->filters['categories'] = $this->getIncomeCategories(true); + $event->class->filters['categories'] = $this->getIncomeCategories(); $event->class->filters['routes']['categories'] = ['categories.index', 'search=type:' . $this->getIncomeCategoryTypes('string') . ' enabled:1']; $event->class->filters['multiple']['categories'] = true; } diff --git a/app/Listeners/Report/AddIncomeExpenseCategories.php b/app/Listeners/Report/AddIncomeExpenseCategories.php index 9552e4fd4..6836552e7 100644 --- a/app/Listeners/Report/AddIncomeExpenseCategories.php +++ b/app/Listeners/Report/AddIncomeExpenseCategories.php @@ -27,8 +27,10 @@ class AddIncomeExpenseCategories extends Listener return; } - $event->class->filters['categories'] = $this->getIncomeExpenseCategories(true); - $event->class->filters['routes']['categories'] = ['categories.index', 'search=type:' . implode(',', array_merge($this->getIncomeCategoryTypes(), $this->getExpenseCategoryTypes())) . ' enabled:1']; + $types = array_merge($this->getIncomeCategoryTypes(), $this->getExpenseCategoryTypes()); + + $event->class->filters['categories'] = $this->getIncomeExpenseCategories(); + $event->class->filters['routes']['categories'] = ['categories.index', 'search=type:' . implode(',', $types) . ' enabled:1']; $event->class->filters['multiple']['categories'] = true; } diff --git a/app/Models/Setting/Category.php b/app/Models/Setting/Category.php index 2f68a75ee..82988c60d 100644 --- a/app/Models/Setting/Category.php +++ b/app/Models/Setting/Category.php @@ -292,10 +292,9 @@ class Category extends Model */ public function getDisplayNameAttribute(): string { - $typeConfig = config('type.category.' . $this->type, []); - $hideCode = isset($typeConfig['hide']) && in_array('code', $typeConfig['hide']); - + $hideCode = $this->hideCodeCategoryType($this->type); $typeNames = $this->getCategoryTypes(); + $typeName = $typeNames[$this->type] ?? ucfirst($this->type); $prefix = (!$hideCode && $this->code) ? $this->code . ' - ' : ''; diff --git a/app/Traits/Categories.php b/app/Traits/Categories.php index aca78c98b..563fdb902 100644 --- a/app/Traits/Categories.php +++ b/app/Traits/Categories.php @@ -36,6 +36,28 @@ trait Categories return in_array($type, $this->getOtherCategoryTypes()); } + public function getTypeCategoryTypes(string $type, string $return = 'array'): string|array + { + switch ($type) { + case Category::INCOME_TYPE: + $types = $this->getIncomeCategoryTypes($return); + break; + case Category::EXPENSE_TYPE: + $types = $this->getExpenseCategoryTypes($return); + break; + case Category::ITEM_TYPE: + $types = $this->getItemCategoryTypes($return); + break; + case Category::OTHER_TYPE: + $types = $this->getOtherCategoryTypes($return); + break; + default: + $types = ($return == 'array') ? [$type] : $type; + } + + return $types; + } + public function getIncomeCategoryTypes(string $return = 'array'): string|array { return $this->getCategoryTypesByIndex(Category::INCOME_TYPE, $return); @@ -98,10 +120,46 @@ trait Categories ])->save(); } - public function getCategoryTypes(bool $translate = true, bool $group = false): array + public function isGroupCategoryType(): bool { - $types = []; - $configs = config('type.category'); + $setting_category_types = setting('category.type'); + + foreach ($setting_category_types as $type => $category) { + $categories = explode(',', $category); + + if (count($categories) > 1) { + return true; + } + } + + return false; + } + + public function hideCodeCategoryType(string $type, bool $default = true): bool + { + return $this->hideCodeCategoryTypes($type)[$type] ?? $default; + } + + public function hideCodeCategoryTypes(string|array $types): array + { + $types = is_string($types) ? explode(',', $types) : $types; + + $type_codes = []; + + foreach ($types as $type) { + $config_type = config('type.category.' . $type, []); + + $type_codes[$type] = ! empty($config_type['hide']) && in_array('code', $config_type['hide']) ? true : false; + } + + return $type_codes; + } + + public function getCategoryTypes(bool $translate = true, bool $group = false, array $types = []): array + { + $category_types = []; + + $configs = empty($types) ? config('type.category') : array_intersect_key(config('type.category'), array_flip($types)); foreach ($configs as $type => $attr) { $plural_type = Str::plural($type); @@ -114,13 +172,14 @@ trait Categories if ($group) { $group_key = $attr['group'] ?? $type; - $types[$group_key][$type] = $translate ? trans_choice($name, 1) : $name; + + $category_types[$group_key][$type] = $translate ? trans_choice($name, 1) : $name; } else { - $types[$type] = $translate ? trans_choice($name, 1) : $name; + $category_types[$type] = $translate ? trans_choice($name, 1) : $name; } } - return $types; + return $category_types; } public function getCategoryTabs(): array diff --git a/app/Traits/Import.php b/app/Traits/Import.php index 827d1df7f..b1f63d29e 100644 --- a/app/Traits/Import.php +++ b/app/Traits/Import.php @@ -57,7 +57,7 @@ trait Import event(new ImportViewCreated($import)); return [ - $import->view, + $import->view, $import->data ]; } @@ -103,7 +103,7 @@ trait Import { $id = isset($row['contact_id']) ? $row['contact_id'] : null; - $type = !empty($type) ? $type : (!empty($row['type']) ? (($row['type'] == Transaction::INCOME_TYPE) ? 'customer' : 'vendor') : 'customer'); + $type = !empty($type) ? $type : (!empty($row['type']) ? (($row['type'] == Transaction::INCOME_TYPE) ? Contact::CUSTOMER_TYPE : Contact::VENDOR_TYPE) : Contact::CUSTOMER_TYPE); if (empty($row['contact_id']) && !empty($row['contact_email'])) { $id = $this->getContactIdFromEmail($row, $type); diff --git a/app/View/Components/Form/Group/Category.php b/app/View/Components/Form/Group/Category.php index e6abde7e0..a7ca6ee17 100644 --- a/app/View/Components/Form/Group/Category.php +++ b/app/View/Components/Form/Group/Category.php @@ -39,27 +39,13 @@ class Category extends Form $this->name = 'category_id'; } - switch ($this->type) { - case Model::INCOME_TYPE: - $types = $this->getIncomeCategoryTypes(); - break; - case Model::EXPENSE_TYPE: - $types = $this->getExpenseCategoryTypes(); - break; - case Model::ITEM_TYPE: - $types = $this->getItemCategoryTypes(); - break; - case Model::OTHER_TYPE: - $types = $this->getOtherCategoryTypes(); - break; - default: - $types = [$this->type]; - } + $types = $this->getTypeCategoryTypes($this->type); + $types_string = implode(',', $types); $this->path = route('modals.categories.create', ['type' => $this->type]); - $this->remoteAction = route('categories.index', ['search' => 'type:' . implode(',', $types) . ' enabled:1']); + $this->remoteAction = route('categories.index', ['search' => 'type:' . $types_string . ' enabled:1']); - $typeLabels = collect($this->getCategoryTypes())->only($types)->all(); + $typeLabels = $this->getCategoryTypes(types: $types); $is_code = false; diff --git a/resources/assets/js/mixins/global.js b/resources/assets/js/mixins/global.js index 3a19616ff..7adcd3f6c 100644 --- a/resources/assets/js/mixins/global.js +++ b/resources/assets/js/mixins/global.js @@ -228,7 +228,7 @@ export default {
- `; + `; item.querySelector('[data-tabs-swiper]').innerHTML = html; slides_view = Number(item.getAttribute('data-swiper')) != 0 ? Number(item.getAttribute('data-swiper')) : slides_view; @@ -301,6 +301,28 @@ export default { this.form[key] = event.target.files[0]; }, + isCategoryCodeFieldVisible() { + if (!this.form || !this.form.type || !this.form.type_codes) { + return false; + } + + let type_codes = this.form.type_codes; + + if (typeof type_codes === 'string') { + try { + type_codes = JSON.parse(type_codes); + } catch (e) { + return false; + } + } + + if (typeof type_codes[this.form.type] === 'undefined') { + return true; + } + + return !Boolean(type_codes[this.form.type]); + }, + // Bulk Action Select all onSelectAllBulkAction() { this.bulk_action.selectAll(); diff --git a/resources/assets/js/views/settings/categories.js b/resources/assets/js/views/settings/categories.js index 683d5f0e4..c60350dd5 100644 --- a/resources/assets/js/views/settings/categories.js +++ b/resources/assets/js/views/settings/categories.js @@ -31,31 +31,15 @@ const app = new Vue({ bulk_action: new BulkAction('categories'), categoriesBasedTypes: null, selected_type: true, - type_codes: {}, - show_code_field: false - } - }, - - mounted() { - if (typeof type_codes !== 'undefined') { - this.type_codes = type_codes; - - if (this.form.type) { - this.show_code_field = this.type_codes[this.form.type] || false; - } } }, methods: { - changeCategories(event) { + updateParentCategories(event) { if (event === '') { return; } - if (this.type_codes[event] !== undefined) { - this.show_code_field = this.type_codes[event]; - } - if (typeof JSON.parse(this.form.categories)[event] === 'undefined') { this.categoriesBasedTypes = []; diff --git a/resources/views/components/form/group/category.blade.php b/resources/views/components/form/group/category.blade.php index 9c7c6de95..11662ef61 100644 --- a/resources/views/components/form/group/category.blade.php +++ b/resources/views/components/form/group/category.blade.php @@ -27,7 +27,7 @@ >